Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sanitizing error messages #653

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: Sanitizing error messages #653

merged 1 commit into from
Dec 23, 2024

Conversation

Stranger6667
Copy link
Owner

TODO:

  • Better naming
  • More flexible sanitized error struct (to_owned?)
  • Update changelog with new naming, etc
  • Rust tests for all the error messages

Resolves #434

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 35.53114% with 176 lines in your changes missing coverage. Please review.

Project coverage is 86.49%. Comparing base (e5b473f) to head (40fc943).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema/src/error.rs 43.69% 125 Missing ⚠️
crates/jsonschema-py/src/lib.rs 0.00% 51 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   87.45%   86.49%   -0.96%     
==========================================
  Files          90       90              
  Lines       13382    13592     +210     
==========================================
+ Hits        11703    11757      +54     
- Misses       1679     1835     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #653 will not alter performance

Comparing dd/rework-errors (40fc943) with master (e5b473f)

Summary

✅ 45 untouched benchmarks

@Stranger6667 Stranger6667 force-pushed the dd/rework-errors branch 3 times, most recently from a9f405d to 1bd48b9 Compare December 23, 2024 00:36
Signed-off-by: Dmitry Dygalo <[email protected]>
@Stranger6667 Stranger6667 merged commit b3d2d6c into master Dec 23, 2024
38 checks passed
@Stranger6667 Stranger6667 deleted the dd/rework-errors branch December 23, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude reflected value in error format?
1 participant