Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use enum dispatch #627

Closed
wants to merge 1 commit into from
Closed

refactor: Use enum dispatch #627

wants to merge 1 commit into from

Conversation

Stranger6667
Copy link
Owner

No description provided.

Signed-off-by: Dmitry Dygalo <[email protected]>
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 90.26549% with 33 lines in your changes missing coverage. Please review.

Project coverage is 87.90%. Comparing base (6b25e32) to head (5dbca06).

Files with missing lines Patch % Lines
...s/jsonschema/src/keywords/additional_properties.rs 59.09% 18 Missing ⚠️
...rates/jsonschema/src/keywords/unevaluated_items.rs 86.66% 4 Missing ⚠️
...rates/jsonschema/src/keywords/exclusive_minimum.rs 66.66% 3 Missing ⚠️
crates/jsonschema/src/keywords/maximum.rs 66.66% 3 Missing ⚠️
crates/jsonschema/src/keywords/mod.rs 91.42% 3 Missing ⚠️
crates/jsonschema/src/node.rs 92.30% 1 Missing ⚠️
crates/jsonschema/src/paths.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #627    +/-   ##
========================================
  Coverage   87.89%   87.90%            
========================================
  Files          92       92            
  Lines       13320    13451   +131     
========================================
+ Hits        11708    11824   +116     
- Misses       1612     1627    +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 26, 2024

CodSpeed Performance Report

Merging #627 will degrade performances by 39.2%

Comparing dd/enum-dispatch (5dbca06) with master (6b25e32)

Summary

❌ 4 regressions
✅ 41 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master dd/enum-dispatch Change
is_valid[CITM/Catalog] 4.8 ms 5.5 ms -13.07%
is_valid[Fast/Invalid] 767.8 ns 961.7 ns -20.16%
is_valid[GeoJSON/Canada] 9.7 ms 15.9 ms -39.2%
validate[GeoJSON/Canada] 9.7 ms 15.9 ms -39.2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant