Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for readyTimeout option #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Paxa
Copy link

@Paxa Paxa commented Oct 22, 2020

#29

Copy link
Collaborator

@Junkern Junkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

It seems like you are using yarn and have changed the .gitignore file causing many unnecessary changes to files and committing the dist repository.

Could you clean up this PR and also change the documentation to document the new option? Thanks :)

@Paxa
Copy link
Author

Paxa commented Oct 22, 2020

Yes. So I can install it from my fork

@Paxa
Copy link
Author

Paxa commented Oct 22, 2020

I removed unnecessary commits

@rathboma
Copy link
Contributor

rathboma commented Mar 8, 2022

@Junkern any chance we can get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants