-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make images and section links relative to the root directory #27
base: master
Are you sure you want to change the base?
Conversation
So if going down this path, it'd be good to have an example, which is where it gets a little tricky. Would the example have the same head as the main page? And if so, it should probably be templated appropriately. At present, if we added an empty page to content/blog (in the example site) we'd just get a blank page of course. I think I'd prefer to have no example link, or a fully working example. |
I believe that in addition to this proposal, which is very timely, we must also define a base template, the theme currently does not have it, I have had to make all these changes to me, and the initial template has been partially rendered. |
What do you mean by a base template? Different to the basic config.yml in the exampleSite directory? |
When I refer to base template, I don't only refer to not limiting the use of the content from the config.toml (It's well done), but instead, expand and promote the use of section page templates, the theme that you publish is amazing, but with great respect, I made changes to improve the ease of making publications in a production site:
I preferred to use the front matter method of defining menu entries:
|
I miss putting absolute paths in the partial header.html and js.html, maybe here they are even more important:
since by extending a new section (for example: a blog), assets would not work.
|
So @braian125 I think you're talking about a different thing here, so I've opened another issue. |
My original intention here was for the blog so things I put in |
On sub-pages, say for a blog, the navigation and images won't work because their paths are relative to the current directory. This works well for single-page sites, where everything is always at the root, but not in this case.
We need to prepend a
/
to all of the locations so that we can explicitly state that all paths start at the root.