Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public modifier to 3 classes to enable linking #558

Closed
wants to merge 1 commit into from

Conversation

shalzuth
Copy link

@shalzuth shalzuth commented Nov 1, 2024

Setting these 3 classes as public allows another C# app to link to the exe and use the it as a reference to download files.
Enables my feature request - #557

Setting these 3 classes as public allows another C# app to link to the exe and use the it as a reference to download files
@xPaw
Copy link
Member

xPaw commented Nov 3, 2024

Can you show an example that would use this?

@shalzuth
Copy link
Author

shalzuth commented Nov 3, 2024

I use it for a Helldivers 2 site I run. I download the content files on the server I host to have auto-updates enabled (and it runs on Linux so it's a bit tricky). I can't run the command line as-is, so I recreate the entry point of DepotDownloader effectively.
I use mostly the same code from https://github.com/SteamRE/DepotDownloader/blob/master/DepotDownloader/Program.cs
https://gist.github.com/shalzuth/440670dbd2b86db1887a7e0fda3c8acf is the code I use. I also do some funny things to make it so I can re-use it within the same process multiple times and not fail on init.

@xPaw
Copy link
Member

xPaw commented Nov 3, 2024

I mean even if we merge this, it still won't be on nuget or be published nupkg, so you'll have to pull in the source/gitmodule this repo.

@shalzuth
Copy link
Author

shalzuth commented Nov 3, 2024

I'd consider this the first of multiple PRs to enable the functionality, to eventually be on nuget.

@yaakov-h
Copy link
Member

yaakov-h commented Nov 4, 2024

Previous discussion about that was here: #146 (comment)

@xPaw
Copy link
Member

xPaw commented Nov 11, 2024

Yeah I agree, I don't think the way this app is implemented is a good idea to expose as a public api.

@xPaw xPaw closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants