Skip to content

Commit

Permalink
[CELEBORN-1263] Fix Master HA mode without internal port error
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?
Master can not start up with ha mode

### Why are the changes needed?
![image](https://github.com/apache/incubator-celeborn/assets/3350718/2856f89e-70bf-4e8e-b05d-5c37cfc6d6b8)

### Does this PR introduce _any_ user-facing change?
no

### How was this patch tested?
local tested

Closes apache#2283 from wxplovecc/fix-ha-internal-port.

Lead-authored-by: 吴祥平 <[email protected]>
Co-authored-by: 吴祥平 <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
2 people authored and pan3793 committed Feb 4, 2024
1 parent fe09e46 commit a8a6e1f
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ class MasterArguments(args: Array[String], conf: CelebornConf) {
val localNode = clusterInfo.localNode
_host = _host.orElse(Some(conf.haMasterNodeHost(localNode.nodeId)))
_port = _port.orElse(Some(conf.haMasterNodePort(localNode.nodeId)))
_internalPort = _internalPort.orElse(Some(conf.haMasterNodeInternalPort(localNode.nodeId)))
_internalPort = _internalPort.orElse {
if (conf.internalPortEnabled) Some(conf.haMasterNodeInternalPort(localNode.nodeId)) else None
}
_masterClusterInfo = Some(clusterInfo)
} else {
_host = _host.orElse(Some(conf.masterHost))
Expand Down

0 comments on commit a8a6e1f

Please sign in to comment.