-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] develop from mermaid-js:develop #21
Conversation
fix: styles for Sankey, Gantt, and User Journey diagrams
Reviewer's Guide by SourceryThis pull request introduces a change that allows the Gantt, Sankey, and User Journey diagrams to pick up the font-family from the mermaid configuration. This change ensures that the font family used in these diagrams is consistent with the overall mermaid configuration, enhancing the visual consistency of the diagrams. Class diagram showing affected diagram style modulesclassDiagram
class MermaidConfig {
+fontFamily: string
}
class GanttStyles {
+getStyles(options)
}
class UserJourneyStyles {
+getStyles(options)
}
class SankeyStyles {
+getStyles(options)
+NEW
}
MermaidConfig --> GanttStyles: uses
MermaidConfig --> UserJourneyStyles: uses
MermaidConfig --> SankeyStyles: uses
note for SankeyStyles "New styles module added"
note for GanttStyles "Updated to use fontFamily from options"
note for UserJourneyStyles "Updated to use fontFamily from options"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Update the Gantt, Sankey, and User Journey diagrams to use the font family specified in the Mermaid configuration.
New Features:
Enhancements: