[Feature] support mac m1 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickif
reviewed
Oct 8, 2022
chaoyli
approved these changes
Oct 8, 2022
rickif
reviewed
Oct 9, 2022
| # reinstall maven and ccache because this two libs counld be installed failed before. | ||
| RUN yum install -y epel-release | ||
| RUN yum install -y maven |
There was a problem hiding this comment.
It seems that maven has been installed with a pre-built binary. Is this necessary?
There was a problem hiding this comment.
In case that install fail before. In my env, I got some failure when install mvn and ccache in pre-built...
| # reinstall maven and ccache because this two libs counld be installed failed before. | ||
| RUN yum install -y epel-release |
There was a problem hiding this comment.
Does the toolchain docker image need these libs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
support build starrocks dev env docker image for mac m1 platform.
Issue
StarRocks/starrocks#11826