Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement OAuth and refactor config #1321

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0f474d8
chore: bump dependencies except librespot and logging
eladyn Oct 21, 2024
0a76720
upgrade to librespot to 0.5 except dbus
eladyn Oct 21, 2024
18978de
dbus_mpris: refactor and remove web API
eladyn Dec 27, 2024
01edb80
chore: update dependencies and librespot to 0.6
eladyn Dec 27, 2024
2f6666f
clippy: fix warnings
eladyn Dec 27, 2024
97846e7
add seeked signal to interface
eladyn Dec 27, 2024
25ee03d
keyring: re-enable real backends
eladyn Dec 27, 2024
aa4cdb9
chore: bump MSRV to 1.81
eladyn Dec 27, 2024
f6dabd2
discovery: shutdown server properly on abort
eladyn Dec 27, 2024
748fdf6
audio: fix volume control by only creating one mixer
eladyn Dec 27, 2024
f70574d
log: silence symphonia info logs
eladyn Dec 27, 2024
310a0fa
mpris: always return at least mpris:trackid
eladyn Dec 29, 2024
3bf0879
mpris: implement OpenUri for all supported types
eladyn Dec 29, 2024
a54e0ce
docs: update docker cross compile guide for librespot 0.6.0 upgrade
mietzen Jan 2, 2025
db5ce48
mpris: disable shuffle setter and manually send repeat changed
eladyn Jan 4, 2025
4542f8c
mpris: do not erase current track on loading event
eladyn Jan 5, 2025
88e0b19
mpris: do not ensure matching track_ids but matching play_request_ids
eladyn Jan 5, 2025
59e8ef0
mpris: simplify play_request_id matching code
eladyn Jan 5, 2025
298afe6
main: use session only once
eladyn Jan 19, 2025
9da692e
config: refactor and replace structopt by clap
eladyn Dec 28, 2024
efd2a6b
config: allow both number and string for initial_volume
eladyn Dec 30, 2024
c94ecc0
auth: implement oauth support
eladyn Dec 30, 2024
fa41e08
chore: properly remove any references to `dbus_keyring` feature
eladyn Dec 30, 2024
82f633d
config: properly handle missing initial_volume
eladyn Jan 19, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ assignees: ''
<!-- if you compiled spotifyd yourself. Alsa backend enabled by default unless compiled with the `--no-default-features` flag -->
**Compilation flags**
- [ ] dbus_mpris
- [ ] dbus_keyring
- [x] alsa_backend
- [ ] portaudio_backend
- [ ] pulseaudio_backend
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
- artifact_type: 'slim' # Slim version has no features enabled by default.
feature: ''
- artifact_type: 'default'
feature: 'dbus_keyring,dbus_mpris' # Default version has all extra features enabled
feature: 'dbus_mpris' # Default version has all extra features enabled
- artifact_type: 'full'
feature: 'dbus_keyring,dbus_mpris' # Full version has all extra features and audio backends enabled
feature: 'dbus_mpris' # Full version has all extra features and audio backends enabled
- build_target: macos
os: macos-latest
artifact_prefix: macos
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
rust: [stable, 1.67]
rust: [stable, 1.81]
os: [macos-latest, ubuntu-latest]
include:
- os: macos-latest
features: portaudio_backend,rodio_backend,dbus_keyring
features: portaudio_backend,rodio_backend
- os: ubuntu-latest
features: alsa_backend,rodio_backend,dbus_keyring,dbus_mpris
features: alsa_backend,rodio_backend,dbus_mpris

steps:
- name: Installing Rust toolchain
Expand Down
Loading
Loading