Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of Seeked MPRIS signal #1315

Closed
wants to merge 1 commit into from

Conversation

dotandl
Copy link
Contributor

@dotandl dotandl commented Dec 19, 2024

This PR adds a lacking definition of the Seeked signal on the org.mpris.MediaPlayer2.Player DBus interface.

While the signal is working and dbus-monitor can listen to it, it is not visible in d-feet and causes problems with some DBus client libraries, e.g. node's dbus-next.

@eladyn
Copy link
Member

eladyn commented Dec 27, 2024

Thank you, that sounds like a good idea. Since I did some major rewrite of the dbus_mpris part recently, I adopted your changes and would merge it as part of that PR (#1317). Does that sound/look good?

@dotandl
Copy link
Contributor Author

dotandl commented Dec 27, 2024

Sure, that sounds great.

@dotandl dotandl closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants