WIP: Sf4 Compat

docs/feed.xml

@@ -1 +1 @@
-<?xml version="1.0" encoding="utf-8"?><feed xmlns="http://www.w3.org/2005/Atom" ><generator uri="https://jekyllrb.com/" version="3.8.7">Jekyll</generator><link href="splashsync.github.io/Widgets-Bundle/feed.xml" rel="self" type="application/atom+xml" /><link href="splashsync.github.io/Widgets-Bundle/" rel="alternate" type="text/html" /><updated>2020-09-23T13:08:16+02:00</updated><id>splashsync.github.io/Widgets-Bundle/feed.xml</id><title type="html">Widgets Bundle</title><subtitle>A full stack bundle for fast integration generic dashboard widgets on Symfony applications.</subtitle></feed>
+<?xml version="1.0" encoding="utf-8"?><feed xmlns="http://www.w3.org/2005/Atom" ><generator uri="https://jekyllrb.com/" version="3.8.7">Jekyll</generator><link href="splashsync.github.io/Widgets-Bundle/feed.xml" rel="self" type="application/atom+xml" /><link href="splashsync.github.io/Widgets-Bundle/" rel="alternate" type="text/html" /><updated>2020-09-23T14:38:49+02:00</updated><id>splashsync.github.io/Widgets-Bundle/feed.xml</id><title type="html">Widgets Bundle</title><subtitle>A full stack bundle for fast integration generic dashboard widgets on Symfony applications.</subtitle></feed>

docs/fr/feed.xml

@@ -1 +1 @@
-<?xml version="1.0" encoding="utf-8"?><feed xmlns="http://www.w3.org/2005/Atom" ><generator uri="https://jekyllrb.com/" version="3.8.7">Jekyll</generator><link href="splashsync.github.io/Widgets-Bundle/fr/feed.xml" rel="self" type="application/atom+xml" /><link href="splashsync.github.io/Widgets-Bundle/fr/" rel="alternate" type="text/html" /><updated>2020-09-23T13:08:16+02:00</updated><id>splashsync.github.io/Widgets-Bundle/feed.xml</id><title type="html">Widgets Bundle</title><subtitle>A full stack bundle for fast integration generic dashboard widgets on Symfony applications.</subtitle></feed>
+<?xml version="1.0" encoding="utf-8"?><feed xmlns="http://www.w3.org/2005/Atom" ><generator uri="https://jekyllrb.com/" version="3.8.7">Jekyll</generator><link href="splashsync.github.io/Widgets-Bundle/fr/feed.xml" rel="self" type="application/atom+xml" /><link href="splashsync.github.io/Widgets-Bundle/fr/" rel="alternate" type="text/html" /><updated>2020-09-23T14:38:49+02:00</updated><id>splashsync.github.io/Widgets-Bundle/feed.xml</id><title type="html">Widgets Bundle</title><subtitle>A full stack bundle for fast integration generic dashboard widgets on Symfony applications.</subtitle></feed>

src/Event/ListingEvent.php

@@ -0,0 +1,25 @@
+<?php
+
+/*
+ *  This file is part of SplashSync Project.
+ *
+ *  Copyright (C) 2015-2020 Splash Sync  <www.splashsync.com>
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ *
+ *  For the full copyright and license information, please view the LICENSE
+ *  file that was distributed with this source code.
+ */
+
+namespace Splash\Widgets\Event;
+
+use Symfony\Component\EventDispatcher\GenericEvent;
+
+/**
+ * Splash Widget Listing Event
+ */
+class ListingEvent extends GenericEvent
+{
+}

src/Resources/config/test.yml

@@ -1,12 +1,10 @@
 services:
 
-    # Test Widgets Factroy Service
+    # Test Widgets Factory Service
     splash.widgets.test.factory:
         class: Splash\Widgets\Tests\Services\SamplesFactoryService
         arguments: ["@splash.widgets.factory"]             
         public:     true
         tags:
-            - { name: kernel.event_listener, event: splash.widgets.list.test,   method: onListingAction }
-            - { name: kernel.event_listener, event: splash.widgets.list.tested, method: onListingAction }
-            - { name: kernel.event_listener, event: splash.widgets.list.demo,   method: onListingAction }
+            - { name: kernel.event_listener, event: Splash\Widgets\Event\ListingEvent,   method: onListingAction }
 

src/Services/ManagerService.php

@@ -16,8 +16,11 @@
 namespace Splash\Widgets\Services;
 
 use Exception;
+use ReflectionException;
+use ReflectionMethod;
 use Splash\Widgets\Entity\Widget;
 use Splash\Widgets\Entity\WidgetCache;
+use Splash\Widgets\Event\ListingEvent;
 use Splash\Widgets\Models\Interfaces\WidgetProviderInterface;
 use Splash\Widgets\Repository\WidgetCacheRepository;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -342,7 +345,7 @@ public function getList(string $mode = self::USER_WIDGETS) : array
         //====================================================================//
         // Execute Listing Event
         /** @var GenericEvent $list */
-        $list = $this->dispatcher->dispatch($mode, new GenericEvent());
+        $list = $this->dispatch(new ListingEvent($mode));
         $widgets = $list->getArguments();
 
         //====================================================================//
@@ -434,4 +437,31 @@ public function cleanCache() : void
     {
         $this->cacheRep->cleanUp();
     }
+
+    /**
+     * Dispatch an Event with Args Detection
+     *
+     * @param ListingEvent $event
+     *
+     * @return null|ListingEvent
+     */
+    private function dispatch(ListingEvent $event): ?ListingEvent
+    {
+        try {
+            $reflection = new ReflectionMethod($this->dispatcher, "dispatch");
+            $args = array();
+            foreach ($reflection->getParameters() as $param) {
+                if ("event" == $param->getName()) {
+                    $args[] = $event;
+                }
+                if ("eventName" == $param->getName()) {
+                    $args[] = get_class($event);
+                }
+            }
+        } catch (ReflectionException $ex) {
+            return null;
+        }
+
+        return $reflection->invokeArgs($this->dispatcher, $args);
+    }
 }

tests/Controller/A001InitialisationControllerTest.php

@@ -56,8 +56,15 @@ public function testDisplayLogo() : void
     public function testCacheClear(string $environement) : void
     {
         //====================================================================//
-        // Create Process
-        $process = new Process("php bin/console cache:clear --no-debug --env=".$environement);
+        // Create Command
+        $command = "php bin/console cache:clear --no-debug --env=".$environement;
+        //====================================================================//
+        // Execute Test (SF 3&4 Versions)
+        try {
+            $process = Process::fromShellCommandline($command);
+        } catch (\Error $exception) {
+            $process = new Process($command);
+        }
 
         //====================================================================//
         // Clean Working Dir

tests/Services/SamplesFactoryService.php

@@ -34,6 +34,10 @@ class SamplesFactoryService extends Base
      */
     public function onListingAction(GenericEvent $event) : void
     {
+        $mode = $event->getSubject();
+        if (!is_string($mode) || !in_array($mode, array("test", "tested", "demo"), true)) {
+            return;
+        }
         $event["Test"] = $this->buildWidgetDefinition("Test")->getWidget();
     }
 }

tests/grumphp/phpstan.neon

@@ -15,4 +15,6 @@ parameters:
                 # Splash Widgets Blocks Methods 
                 - '#Call to an undefined method [a-zA-Z0-9\\_]+BaseBlock::[a-zA-Z0-9\\_]+().#'
                 - '#Call to an undefined method [a-zA-Z0-9\\_]+FactoryService::[a-zA-Z0-9\\_]+().#'
-
+               # For Compat with Symfony 3 & 4
+                - '#Parameter \#1 \$command of class [a-zA-Z0-9\\]+Process constructor expects array, string given.#'
+                - '#Call to an undefined static method [a-zA-Z0-9\\]+Process::fromShellCommandline().#'

web/app.php

@@ -19,14 +19,7 @@
 
 /** @var \Composer\Autoload\ClassLoader $loader */
 $loader = require __DIR__.'/../app/autoload.php';
-if (PHP_VERSION_ID < 70000) {
-    include_once __DIR__.'/../var/bootstrap.php.cache';
-}
-
 $kernel = new AppKernel('dev', true);
-if (PHP_VERSION_ID < 70000) {
-    $kernel->loadClassCache();
-}
 
 $request = Request::createFromGlobals();
 $response = $kernel->handle($request);

web/app_test.php

@@ -29,10 +29,6 @@
 require_once __DIR__.'/../app/AppKernel.php';
 
 $kernel = new AppKernel('test', true);
-if (PHP_VERSION_ID < 70000) {
-    $kernel->loadClassCache();
-}
-
 $request = Request::createFromGlobals();
 $response = $kernel->handle($request);
 $response->send();