FIX: Négative Order Totals VAT

SplashSync · Jan 24, 2023 · 7d23eb0 · 7d23eb0
1 parent fe261e4
commit 7d23eb0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/grumphp.yml b/grumphp.yml
@@ -37,7 +37,7 @@ parameters:
     # For Building Splash Module
     mod-src:            '/modules/splashsync'
     mod-target:         '/splashsync/'
-    mod-file:           "splashsync.1.7.2"
+    mod-file:           "splashsync.1.7.3"
 
     # For Building Splash Manifest
     yml-enable:     false

diff --git a/modules/splashsync/splashsync.php b/modules/splashsync/splashsync.php
@@ -74,7 +74,7 @@ public function __construct()
         // Init Module Main Information Fields
         $this->name = 'splashsync';
         $this->tab = 'administration';
-        $this->version = '1.7.2';
+        $this->version = '1.7.3';
         $this->author = 'SplashSync';
         $this->need_instance = 0;
         $this->ps_versions_compliancy = array('min' => '1.6', 'max' => '1.7');

diff --git a/modules/splashsync/src/Objects/Order/TotalsTrait.php b/modules/splashsync/src/Objects/Order/TotalsTrait.php
@@ -141,7 +141,7 @@ private function getTotalsFields(string $key, string $fieldName): void
      */
     private static function toVatPercents(float $priceTaxExcl, float $priceTaxIncl): float
     {
-        return (($priceTaxExcl > 0) && ($priceTaxIncl > 0))
+        return (($priceTaxExcl > 0) && ($priceTaxIncl > 0) && ($priceTaxExcl <= $priceTaxIncl))
             ? 100 * ($priceTaxIncl - $priceTaxExcl) / $priceTaxExcl
             : 0.0
         ;