FIX: Invoices Paid Status

SplashSync · Jan 8, 2025 · 72d1ecc · 72d1ecc
1 parent 8ddfb08
commit 72d1ecc
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/modules/splashsync/src/Objects/Invoice/StatusTrait.php b/modules/splashsync/src/Objects/Invoice/StatusTrait.php
@@ -98,10 +98,9 @@ private function getStatusFields($key, $fieldName)
             // INVOICE STATUS
             //====================================================================//
             case 'status':
-                $delta = $this->object->getTotalPaid() - $this->object->total_paid_tax_incl;
                 if (!$this->order->valid) {
                     $this->out[$fieldName] = "PaymentCanceled";
-                } elseif (($delta < 1E-6) || ($delta > 0)) {
+                } elseif ($this->isPaidInvoice()) {
                     $this->out[$fieldName] = "PaymentComplete";
                 } else {
                     $this->out[$fieldName] = "PaymentDue";
@@ -120,8 +119,7 @@ private function getStatusFields($key, $fieldName)
 
                 break;
             case 'isPaid':
-                $delta = $this->object->getTotalPaid() - $this->object->total_paid_tax_incl;
-                $this->out[$fieldName] = (($delta < 1E-6) || ($delta > 0));
+                $this->out[$fieldName] = $this->isPaidInvoice();
 
                 break;
             default:
@@ -131,6 +129,18 @@ private function getStatusFields($key, $fieldName)
         unset($this->in[$key]);
     }
 
+    /**
+     * Check if Invoice is Paid
+     *
+     * @return bool
+     */
+    private function isPaidInvoice(): bool
+    {
+        $delta = $this->object->getTotalPaid() - $this->object->total_paid_tax_incl;
+
+        return  ((abs($delta) < 1E-6) || ($delta > 0));
+    }
+
     //====================================================================//
     // Fields Writting Functions
     //====================================================================//