FIX: Msf update Fields

SplashSync · Oct 13, 2020 · 55c3eb0 · 55c3eb0
1 parent a0e7580
commit 55c3eb0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/modules/splashsync/src/Objects/Product/AttributeTrait.php b/modules/splashsync/src/Objects/Product/AttributeTrait.php
@@ -149,7 +149,7 @@ public function updateAttribute()
         //====================================================================//
         // FORCE MSF FIELDS WRITING
         $updateFields = $this->getMsfUpdateFields("Attribute");
-        if ($updateFields) {
+        if (is_array($updateFields)) {
             $this->Attribute->setFieldsToUpdate($updateFields);
         }
         //====================================================================//

diff --git a/modules/splashsync/src/Objects/Product/CRUDTrait.php b/modules/splashsync/src/Objects/Product/CRUDTrait.php
@@ -150,7 +150,7 @@ public function update($needed)
             //====================================================================//
             // FORCE MSF FIELDS WRITING
             $updateFields = $this->getMsfUpdateFields("Product");
-            if ($updateFields) {
+            if (is_array($updateFields)) {
                 $this->object->setFieldsToUpdate($updateFields);
             }
             if (true != $this->object->update()) {

diff --git a/modules/splashsync/tests/L10MsfProductsTest.php b/modules/splashsync/tests/L10MsfProductsTest.php
@@ -199,11 +199,10 @@ private function isAllowedFieldForTesting($field): bool
         }
         //====================================================================//
         //   Ensure Field is Msf Field
-        if (!isset($field->options, $field->options["shop"])) {
-            return false;
-        }
-        if (MSM::MODE_ALL == $field->options["shop"]) {
-            return false;
+        if (isset($field->options, $field->options["shop"])) {
+            if (MSM::MODE_ALL == $field->options["shop"]) {
+                return false;
+            }
         }
         if (!isset($field->id) || (false !== strpos($field->id, "_shop_"))) {
             return false;