Move FPGA/Spinnaker links creation data to Version #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the adding of FPGA and spinnaker links was handled by Machine based purely on the Machine's width and height.
This PR moves the data behind the adding of the links to the Versions
Getting the FPGA has been simplified from a fancy formula to a hard coded list
Based on:
https://drive.google.com/file/d/0B9312BuJXntlVWowQlJ3RE8wWVE/view?usp=sharing&resourcekey=0--Ypo5k1k8j20R9O3ZDu-YA
Added extra testing by
Tested by:
SpiNNakerManchester/IntegrationTests#265
====
Note:
I noticed that spinnaker links are only added if the link is not used.
FPGA links are added EVEN if the link is used.
So multi board machines have FPGA links even though the hardware is used for board to board connectivity.
Would be very easy to change!