Add provenance writing for app_vertex #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-B
reviewed
Oct 27, 2021
|
|
||
| def test_app_vertex(self): | ||
| with ProvenanceWriter() as db: | ||
| db.insert_app_vertex("pop", "type", "description", 0.5) |
There was a problem hiding this comment.
The type tested here does not match the CREATE TABLE.
While it works it is not the cleanest
There was a problem hiding this comment.
Oops - good spot, edited.
|
Approved to merge when you want into whichever branch you feel best |
This was referenced Nov 11, 2021
Conflicts: spinn_front_end_common/interface/provenance/db.sql spinn_front_end_common/interface/provenance/provenance_writer.py unittests/interface/provenance/test_provenance_database.py
|
Should the field and param "population" not be "label". At the FEC level there are no Populations (minor) You are actually saving the AbstractPopulationVertex.label. (Yes I know that is typically also the population label) Would allow the table/ method also to be used for none Population Vertices |
Conflicts: spinn_front_end_common/interface/provenance/db.sql spinn_front_end_common/interface/provenance/provenance_writer.py
- move DataType changes from DataSpecification here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of SpiNNakerManchester/sPyNNaker#852