Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5525 Set NTLM Feature Flag Default To Disabled & Update NTLMSMB General Copy #1198

Conversation

mvlipka
Copy link
Contributor

@mvlipka mvlipka commented Mar 5, 2025

Description

Change NTLMToSMB's General copy to reference Composition instead of Relay Targets
Default NTLM feature flag to disabled

Motivation and Context

This PR addresses: BED-5525

How Has This Been Tested?

image

With a fresh instance of BHE I ingested data and ensured no NTLM edges were created.
I then enabled the NTLM feature flag and re-ingested the same zip and confirmed that the edges were created

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Database Migrations

Checklist:

… Relay Targets and set NTLM feature flag to off by default
@mvlipka mvlipka marked this pull request as ready for review March 5, 2025 16:38
@mvlipka mvlipka added the bug Something isn't working label Mar 5, 2025
@mvlipka mvlipka merged commit a9dc978 into stage/v7.1.0 Mar 5, 2025
6 checks passed
@mvlipka mvlipka deleted the BED-5525/NTLMSMB-FixCompositionCopy-NTLMFeatureFlagDefaultOff branch March 5, 2025 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants