Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update t0 label const name to disambiguate from high value #1196

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix: update t0 label const name to disambiguate from high value #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmd/ui/src/views/GroupManagement/GroupManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ import {
DropdownOption,
EntityKinds,
GroupManagementContent,
HIGH_VALUE_LABEL,
Permission,
searchbarActions,
TIER_ZERO_LABEL,
TIER_ZERO_TAG,
searchbarActions,
usePermissions,
} from 'bh-shared-ui';
import { AssetGroup, AssetGroupMember } from 'js-client-library';
Expand Down Expand Up @@ -74,7 +74,7 @@ const GroupManagement = () => {
const isTierZero = assetGroup.tag === TIER_ZERO_TAG;
return {
key: assetGroup.id,
value: isTierZero ? TIER_ZERO_LABEL : assetGroup.name,
value: isTierZero ? HIGH_VALUE_LABEL : assetGroup.name,
icon: isTierZero ? faGem : undefined,
};
});
Expand All @@ -84,7 +84,7 @@ const GroupManagement = () => {
<GroupManagementContent
globalDomain={globalDomain}
showExplorePageLink={!!openNode}
tierZeroLabel={TIER_ZERO_LABEL}
tierZeroLabel={HIGH_VALUE_LABEL}
tierZeroTag={TIER_ZERO_TAG}
// Both these components should eventually be moved into the shared UI library
entityPanelComponent={<EntityInfoPanel selectedNode={openNode} />}
Expand Down
8 changes: 6 additions & 2 deletions packages/javascript/bh-shared-ui/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,13 @@ export const NODE_GRAPH_RENDER_LIMIT = 1000;

export const ZERO_VALUE_API_DATE = '0001-01-01T00:00:00Z';

export const TIER_ZERO_TAG = 'admin_tier_0';
export const TIER_ZERO_LABEL = 'High Value';
// These tags are values associated with the `system_tags` property of a node
export const OWNED_OBJECT_TAG = 'owned';
export const TIER_ZERO_TAG = 'admin_tier_0';

// These labels are used as display values
export const TIER_ZERO_LABEL = 'Admin Tier Zero';
export const HIGH_VALUE_LABEL = 'High Value';

export const lightPalette = {
primary: {
Expand Down
Loading