Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5464 - Additional CySQL Fixes #1189

Merged
merged 3 commits into from
Mar 4, 2025
Merged

BED-5464 - Additional CySQL Fixes #1189

merged 3 commits into from
Mar 4, 2025

Conversation

zinic
Copy link
Contributor

@zinic zinic commented Mar 4, 2025

Description

This changeset addresses a few tickets:

  • BED-5464
  • BP-1396
  • And an additional test case missed for BP-1366

Motivation and Context

Refactors to better support more robust translations for complex user queries. Some of these ended up stressing some shortcuts and hacks in managing symbols that get projected between query steps.

How Has This Been Tested?

More test cases added for each ticket.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

…ranslate with to support better group by logic
@zinic zinic changed the base branch from main to stage/v7.1.0 March 4, 2025 07:08
Copy link
Contributor

@wes-mil wes-mil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fully comprehend what's happening, but I see no glaring issues and tests passing

@zinic zinic merged commit f13ea02 into stage/v7.1.0 Mar 4, 2025
6 checks passed
@zinic zinic deleted the cysql branch March 4, 2025 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants