Bed 4969: Direct Access Users group missing from collection or post-p…

…rocessing (#1115)

* Do not throw away ADLocalGroups with 0 members if the group name begins with Direct Access Users

* Clean up

cmd/api/src/daemons/datapipe/convertors.go

@@ -17,6 +17,8 @@
 package datapipe
 
 import (
+	"strings"
+
 	"github.com/specterops/bloodhound/ein"
 	"github.com/specterops/bloodhound/graphschema/ad"
 )
@@ -34,7 +36,8 @@ func convertComputerData(computer ein.Computer, converted *ConvertedData) {
 
 	converted.RelProps = append(converted.RelProps, ein.ParseComputerMiscData(computer)...)
 	for _, localGroup := range computer.LocalGroups {
-		if !localGroup.Collected || len(localGroup.Results) == 0 {
+		// throw away groups with 0 members unless the group name begins with "DIRECT ACCESS USERS"
+		if !localGroup.Collected || (len(localGroup.Results) == 0 && !strings.HasPrefix(strings.ToUpper(localGroup.Name), "DIRECT ACCESS USERS")) {
 			continue
 		}