Revert fan RPM "optimisation" due to breakage

Integer math, my beloved...
Sparronator9999 · Dec 19, 2024 · 31d87d7 · 31d87d7
1 parent 3f6132b
commit 31d87d7
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/YAMDCC.Service/FanControlService.cs b/YAMDCC.Service/FanControlService.cs
@@ -590,21 +590,20 @@ private int GetFanRPM(int clientId, string args)
                 if (success)
                 {
                     int rpm;
-                    if (rpmValue <= 0)
+#pragma warning disable IDE0045 // Supress "if statement can be simplified" suggestion
+                    if (cfg.RPMConf.Invert)
                     {
-                        rpm = 0;
+                        rpm = cfg.RPMConf.DivideByMult
+                            ? cfg.RPMConf.RPMMult / rpmValue
+                            : 1 / (rpmValue * cfg.RPMConf.RPMMult);
                     }
                     else
                     {
                         rpm = cfg.RPMConf.DivideByMult
                             ? rpmValue / cfg.RPMConf.RPMMult
                             : rpmValue * cfg.RPMConf.RPMMult;
-
-                        if (cfg.RPMConf.Invert)
-                        {
-                            rpm = 1 / rpm;
-                        }
                     }
+#pragma warning restore IDE0045
                     IPCServer.PushMessage(new ServiceResponse(
                         Response.FanRPM, $"{rpm}"), clientId);
                     return 0;