Fix case of boolean string in boolean example #3
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I try "boolean_client.py" with arduino Yun "Spacebrew Boolean" example program. I have some issues since arduino spacebrew library wait for "true" or "false" string at lowercase. Python use "True" and "False" string for boolean. This commit fix it.
|
Does anyone know why we are using String representation of true/false instead of JSON representation of true/false? I have a hunch it was a bug somewhere in an early lib that we didn't feel like investigating.... I would rather fix the problem than the symptom. |
|
We've created a version of the python library specifically for the Arduino Yun, which is located here - https://github.com/julioterra/yunSpacebrew. Please use that version of the library instead. Quin, I agree with your suggestion. I don't know why we didn't use the JSON representation earlier but we should do so now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try "boolean_client.py" with arduino Yun "Spacebrew Boolean" example program. I have some issues since arduino spacebrew library wait for "true" or "false" string at lowercase. Python use "True" and "False" string for boolean. This commit fix it.