Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: 분류 카드 컴포넌트 구현 #30

Merged
merged 2 commits into from
Oct 27, 2023
Merged

design: 분류 카드 컴포넌트 구현 #30

merged 2 commits into from
Oct 27, 2023

Conversation

SongInjae
Copy link
Collaborator

📝요구사항과 구현내용

  • 작업 내용 1: 분류 카드 컴포넌트를 구현했습니다.

구현 스크린샷

스크린샷 2023-10-27 오전 11 17 29

✨pr포인트 & 궁금한 점

  • 카드의 색깔은 임시입니다. 레이아웃 위주로 확인 부탁드립니다.

@SongInjae SongInjae added the good first issue Good for newcomers label Oct 27, 2023
@SongInjae SongInjae self-assigned this Oct 27, 2023
hyesung99
hyesung99 previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@hyesung99 hyesung99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

src/components/ClassificationCard/Card.tsx Outdated Show resolved Hide resolved
src/components/ClassificationCard/Card.tsx Outdated Show resolved Hide resolved
src/components/ClassificationCard/Card.style.ts Outdated Show resolved Hide resolved
colorkite10
colorkite10 requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@colorkite10 colorkite10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혜성님이 이미 리뷰를 다 남겨 주셔서 제가 추가로 코멘트 달 부분은 없었습니다!
별개로 피그마에 행사 종류 선택 카드 색상을 설정해보았으니 확인해보시고 의견 달아주시면 감사하겠습니다!

수고하셨습니다 :)

colorkite10
colorkite10 previously approved these changes Oct 27, 2023
View reviewed changes
@SongInjae SongInjae dismissed stale reviews from colorkite10 and hyesung99 via d441e03 October 27, 2023 04:53
@SongInjae SongInjae merged commit 66509ec into main Oct 27, 2023
@hyesung99 hyesung99 deleted the SKRF-158-design-event-devision-comp branch October 31, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colorkite10 colorkite10 colorkite10 approved these changes

@hyesung99 hyesung99 hyesung99 approved these changes

Assignees

@SongInjae SongInjae

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SongInjae @hyesung99 @colorkite10