SKRF-461 fix: 비로그인시 북마크 제한 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colorkite10
previously approved these changes
Dec 1, 2023
| @@ -59,7 +60,7 @@ const UserApplyButton = ({ eventId, eventDetail, applyModalOpen }: UserApplyButt | |||
| > | |||
| {getApplyButtonText()} | |||
| </ApplyButton> | |||
| <BookmarkButton reverse bold onClick={() => bookmarkRef.current?.click()}> | |||
| <BookmarkButton reverse bold disabled={!isToken} onClick={() => bookmarkRef.current?.click()}> | |||
There was a problem hiding this comment.
참여신청하기 버튼처럼 로그인을 하지 않고 북마크 버튼을 누르면 안내 모달을 띄우면 좋을 것 같습니다!
There was a problem hiding this comment.
저도 하려다가 조금 걸릴 것 같아서 이렇게 했는데 딱 걸렸네요😅
hyesung99
previously approved these changes
Dec 1, 2023
SongInjae
force-pushed
the
SKRF-461-nonlogin-bookmark-bug
branch
from
5e170c2 to
32017c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝요구사항과 구현내용
구현 스크린샷
✨pr포인트 & 궁금한 점