Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKRF-459 fix : 폼 옵션 설정 페이지 4차 QA #217

Merged
merged 6 commits into from
Dec 1, 2023
Merged

SKRF-459 fix : 폼 옵션 설정 페이지 4차 QA #217

merged 6 commits into from
Dec 1, 2023

Conversation

hyesung99
Copy link
Collaborator

📝요구사항과 구현내용

  • 폼 레이아웃 스타일 수정 ( height : 3.5rem 설정 되어있던거 지웠습니다 지워도 되는걸까요?? )
  • 최대 옵션 항목 수 추가 (20개)
  • 이미 폼 옵션 설정한 행사 예외 처

구현 스크린샷

image
image

✨pr포인트 & 궁금한 점

@hyesung99 hyesung99 self-assigned this Dec 1, 2023
colorkite10
colorkite10 previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@colorkite10 colorkite10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 :)

SongInjae
SongInjae previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@SongInjae SongInjae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다:)

src/App.tsx
<Outlet />
</div>
);
return <Outlet />;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

colorkite10
colorkite10 previously approved these changes Dec 1, 2023
View reviewed changes
@hyesung99 hyesung99 dismissed stale reviews from colorkite10 and SongInjae via 73ef886 December 1, 2023 06:52
@hyesung99 hyesung99 merged commit baf4e2f into main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colorkite10 colorkite10 colorkite10 left review comments

@SongInjae SongInjae SongInjae left review comments

Assignees

@hyesung99 hyesung99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyesung99 @SongInjae @colorkite10