Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKRF-452 refactor: submitted forms page exception #214

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

colorkite10
Copy link
Collaborator

@colorkite10 colorkite10 commented Dec 1, 2023

๐Ÿ“์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๊ตฌํ˜„๋‚ด์šฉ

  • ์ œ์ถœ๋œ ํผ ํŽ˜์ด์ง€์—์„œ ๊ณต์—ฐ ์นดํ…Œ๊ณ ๋ฆฌ์ผ ๋•Œ '์ธ์›์ˆ˜'๋ฅผ ๋ณด์—ฌ์ค๋‹ˆ๋‹ค.
  • ์ƒํƒœ๋ณ€๊ฒฝ๋ฒ„ํŠผ ํด๋ฆญ ์‹œ ๋ชจ๋‹ฌ ๋ฉ”์‹œ์ง€ "ํ™•์ธ"->"์Šน์ธ"
  • ์ทจ์†Œ์š”์ฒญ์ผ ๋•Œ ์ƒํƒœ๋ณ€๊ฒฝ ๋ถˆ๊ฐ€๋Šฅ

๊ตฌํ˜„ ์Šคํฌ๋ฆฐ์ƒท

image
image
image

โœจprํฌ์ธํŠธ & ๊ถ๊ธˆํ•œ ์ 

@colorkite10 colorkite10 self-assigned this Dec 1, 2023
hyesung99
hyesung99 previously approved these changes Dec 1, 2023
@@ -8,14 +8,21 @@ interface FormDetailModalProps {
onClose: () => void;
options: { title: string; content: string }[];
nthForm: number;
ticketCount: string | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2;

Suggested change
ticketCount: string | null;
ticketCount?: string;

์ด๋ ‡๊ฒŒํ•˜๋ฉด ๋ ๋“ฏ ํ•˜๋„ค์š”!

Copy link
Collaborator

@SongInjae SongInjae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค:)

@colorkite10 colorkite10 merged commit 95117ff into main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants