SKRF-447 행사정보 작성페이지 2차 QA #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesung99
previously approved these changes
Dec 1, 2023
Comment on lines
5
to
44
| const EventFormContainer = styled.form` | ||
| display: flex; | ||
| position: relative; | ||
| flex-wrap: wrap; | ||
| width: 100%; | ||
| height: 100%; | ||
| padding: 3rem 0; | ||
|
|
||
| & > div:first-of-type { | ||
| padding-right: 1.5rem; | ||
| border-right: 1px solid ${Theme.color.tSeparator}; | ||
| @media (min-width: 1023px) { | ||
| padding-right: 1.5rem; | ||
| border-right: 1px solid ${Theme.color.tSeparator}; | ||
| } | ||
| } | ||
|
|
||
| & > div:nth-last-of-type(2) { | ||
| padding-left: 1.5rem; | ||
| @media (min-width: 1023px) { | ||
| padding-left: 1.5rem; | ||
| } | ||
| } | ||
| & > div:first-child > div:nth-last-of-type(2) { | ||
| flex-grow: 1; | ||
| } | ||
| `; | ||
| const ContentArea = styled.div` | ||
| width: 50%; | ||
| min-width: 50%; | ||
| min-height: 100%; | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 1rem; | ||
|
|
||
| & > div:last-of-type { | ||
| @media (max-width: 1023px) { | ||
| padding-bottom: 1.5rem; | ||
| margin-bottom: 2rem; | ||
| } | ||
| } | ||
| `; | ||
| const TwoInputContainer = styled.div` | ||
| display: flex; |
There was a problem hiding this comment.
const EventFormContainer = styled.form`
display: flex;
position: relative;
flex-wrap: wrap;
width: 100%;
height: 100%;
padding: 3rem 0;
gap: 1rem;
`;
const ContentArea = styled.div`
flex-grow: 1;
display: flex;
flex-direction: column;
gap: 1rem;
`;
const TwoInputContainer = styled.div`
display: flex;
gap: 0.5rem;
&:last-of-type {
padding-top: 1rem;
border-top: 1px solid ${Theme.color.tSeparator};
}
`;이렇게 하는걸 의도하신게 아닐까 생각하고 수정해봤어요! 한번 적용하고 확인 부탁드립니다!
There was a problem hiding this comment.
감사합니다!! 일부 수정하여 반영했습니다:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝요구사항과 구현내용
구현 스크린샷
✨pr포인트 & 궁금한 점