Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InputForm 컴포넌트 구현 #15

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

SongInjae
Copy link
Collaborator

@SongInjae SongInjae commented Oct 24, 2023

📝요구사항과 구현내용

  • 작업 내용 1: InputForm 공통 컴포넌트를 구현했습니다.

  • 매개변수

    • wrapperWidth: 겉 껍데기의 width -> string => optional
    • labelText: label의 text값 -> string
    • labelId: input과 연결시키기 위한 id -> string
    • inputType: input태그의 type -> 'date' | 'file' | 'number' | 'search' | 'tel' | 'text' | 'time'
    • 그 외에 input에 들어갈 내용을 커스터마이징 할 수 있도록 ...props를 넣었습니다!

input style 커스터마이징하기

const InputFormStyled = styled(InputForm)`
  // 어쩌구 저쩌구
`

input 안에 속성들 넣기

<InputForm value={value} onChange={handleChange} ref={inputRef} />

✨pr포인트 & 궁금한 점

  • style 부분에 더 최소화할 수 있는 점이 있는지 봐주시면 감사하겠습니다.

@SongInjae SongInjae added the good first issue Good for newcomers label Oct 24, 2023
@SongInjae SongInjae self-assigned this Oct 24, 2023
Copy link
Collaborator

@colorkite10 colorkite10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@SongInjae SongInjae merged commit 3015238 into main Oct 24, 2023
2 checks passed
@SongInjae SongInjae deleted the SKRF-145-feat-create-inputform branch October 24, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants