session_timeout: make sure remember_me's before_logout hook gets called #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
session_timeout
as well as theremember_me
submodule the following can happen:invalidate_sessions_before
timestamp is set tonow
, their remember_me sessions will not be invalidatedsession_timeout
submodule'svalidate_session
In the code
only
logout
calls before & after logout hooks:sorcery/lib/sorcery/controller.rb
Lines 75 to 78 in d9dc0bd
remember_me
uses abefore_logout
hook to clear its cookie:sorcery/lib/sorcery/controller/submodules/remember_me.rb
Line 22 in d9dc0bd