Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sorcery CA bundle #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anaumov
Copy link
Contributor

@anaumov anaumov commented Jul 25, 2019

I faced with SLL issue on VK auth. An issue described here #125. I found that CA bundle was updated 6 years ago. Here a new one. I downloaded it from https://curl.haxx.se/docs/caextract.html. Let me know if you have any questions.

@anaumov anaumov force-pushed the feature/update_ca_cert branch from f9f835a to ef9813f Compare July 25, 2019 12:53
@anaumov
Copy link
Contributor Author

anaumov commented Jul 31, 2019

@athix can you take a look?

@joshbuker
Copy link
Member

Updating the certificate authorities sounds like a high-risk change, so I'm hesitant to merge this without thoroughly validating the new list. If you have resources to help validate the authenticity, I can get this in sooner. Otherwise it will have to wait until I have time to look further into the issue.

Sorry for the inconvenience! In the short-term, you should be able to point your project at your fork with the ca changes.

@anaumov
Copy link
Contributor Author

anaumov commented Aug 21, 2019

@athix Not sure how to validate it automatically. Will take a look and get back.

@joshbuker
Copy link
Member

Hi @anaumov, any luck?

@joshbuker joshbuker mentioned this pull request Dec 19, 2019
@anaumov
Copy link
Contributor Author

anaumov commented Dec 19, 2019

@athix will get back to this PR next week. Sorry for the delay.

@anaumov
Copy link
Contributor Author

anaumov commented Jan 10, 2020

I did research about this PEM file. It made by the tool mk-ca-bundle from creators of the curl. It downloads a file with all authorized providers from Mozilla. Then it converts a file to PEM format. That's it.

I looks ok to me to use the tool from creators of curl and Mozilla CA data. What do you think, @athix?

Resources:
Mozzila certificate store
Mozzila certdata file
mk-ca-bundle man page
mk-ca-bundle source code

@joshbuker
Copy link
Member

@anaumov I'll look into implementing this in the v1 rework, although it may become obsolete if we move the provider system to use omniauth instead of directly calling oauth2.

@joshbuker joshbuker added the to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed. label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants