Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keychron C1 RGB support. #386

Merged
merged 17 commits into from
Jul 5, 2024
Merged

Conversation

NetUserGet
Copy link

Update Keychron C1 RGB support from sn32_master.

Description

Full support for RGB, status indicators, and dip switch.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Following the keychron structure, this should change to c1/rgb/ ( there are other variants with a different chip). Please see other merged K* keyboards.

Also a bonus, it's a good idea to fix the LED flags - https://github.com/SonixQMK/qmk_firmware/blob/sn32_develop/docs/features/rgb_matrix.md#flags-flags 4 is only on alphas, mods need a different flag

@github-actions github-actions bot added the via label Jul 4, 2024
@dexter93 dexter93 merged commit a55b7bf into SonixQMK:sn32_develop Jul 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants