-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keychron C1 RGB support. #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Following the keychron structure, this should change to c1/rgb/
( there are other variants with a different chip). Please see other merged K* keyboards.
Also a bonus, it's a good idea to fix the LED flags - https://github.com/SonixQMK/qmk_firmware/blob/sn32_develop/docs/features/rgb_matrix.md#flags-flags 4
is only on alphas, mods need a different flag
… favor for the built-in reboot keycode, and rename c1.c to rgb.c
…b with an RGB_MATRIX_ENABLE ifdef.
…r keyboard_name and swap RGB_MATRIX_ENABLE with RGB_MATRIX_SLEEP in rgb.c
Update Keychron C1 RGB support from sn32_master.
Description
Full support for RGB, status indicators, and dip switch.
Types of Changes
Issues Fixed or Closed by This PR
Checklist