SLI-129 Login/password authentication fails

SonarSource · Nov 18, 2016 · b6b0bf1 · b6b0bf1
1 parent 5443b0d
commit b6b0bf1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/main/java/org/sonarlint/intellij/config/global/SonarQubeServer.java b/src/main/java/org/sonarlint/intellij/config/global/SonarQubeServer.java
@@ -170,12 +170,20 @@ public Builder setEnableProxy(boolean enableProxy) {
     }
 
     public Builder setToken(@Nullable String token) {
-      this.token = PasswordUtil.encodePassword(token);
+      if (token == null) {
+        this.token = null;
+      } else {
+        this.token = PasswordUtil.encodePassword(token);
+      }
       return this;
     }
 
     public Builder setPassword(@Nullable String password) {
-      this.password = PasswordUtil.encodePassword(password);
+      if (password == null) {
+        this.password = null;
+      } else {
+        this.password = PasswordUtil.encodePassword(password);
+      }
       return this;
     }
 

diff --git a/src/main/java/org/sonarlint/intellij/util/SonarLintUtils.java b/src/main/java/org/sonarlint/intellij/util/SonarLintUtils.java
@@ -256,7 +256,7 @@ public static ServerConfiguration getServerConfiguration(SonarQubeServer server)
       .connectTimeoutMilliseconds(CONNECTION_TIMEOUT_MS)
       .readTimeoutMilliseconds(CONNECTION_TIMEOUT_MS)
       .url(server.getHostUrl());
-    if (server.getToken() != null) {
+    if (StringUtil.isNotEmpty(server.getToken())) {
       serverConfigBuilder.token(server.getToken());
     } else {
       serverConfigBuilder.credentials(server.getLogin(), server.getPassword());