Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-6326: add environment as optional input #19

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jayadeep-km-sonarsource
Copy link
Contributor

@jayadeep-km-sonarsource jayadeep-km-sonarsource commented Sep 23, 2024

BUILD-6326: add environment as optional input

This is required in repositories where environment is part of the OIDC sub claims. Otherwise the action will throw an error

OIDC error: the claim 'environment' cannot be `null` or empty. The following claims specified by the `include_claim_keys` setting must be set: repo, environment, ref. See <https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#understanding-the-oidc-token> for more information.

More info in the ticket.

Tested in https://github.com/SonarSource/sonar-dummy/actions/runs/10996256142/job/30528993844

Signed-off-by: Jayadeep Kinavoor Madam <[email protected]>
@jayadeep-km-sonarsource jayadeep-km-sonarsource marked this pull request as ready for review September 23, 2024 14:23
@jayadeep-km-sonarsource jayadeep-km-sonarsource requested a review from a team as a code owner September 23, 2024 14:23
@jayadeep-km-sonarsource jayadeep-km-sonarsource merged commit d3df911 into master Sep 23, 2024
1 check passed
@jayadeep-km-sonarsource jayadeep-km-sonarsource deleted the feat/jd/BUILD-6326-environment-name branch September 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants