Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 카카오 로그인 Redirect URI 동적 할당 #62

Closed
wants to merge 3 commits into from

Conversation

junseoplee
Copy link
Collaborator

💡 연관된 이슈

#61

📝 작업 내용

💬 리뷰 요구 사항

@junseoplee junseoplee added the ✨ Feature 기능 개발 label Oct 7, 2024
@junseoplee junseoplee self-assigned this Oct 7, 2024
private String productionRedirectUri;

public KakaoLoginServiceRequest convertKakaoLoginRequest(HttpServletRequest request, String code) {
String redirectUri = request.getServerName().equals("localhost") ? localRedirectUri : productionRedirectUri;
Copy link
Collaborator

@yongbin97 yongbin97 Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3항 연산자 분리해주세요~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바꿨는데 push가 안됐었네요.
근데 이거 테스트만 해보고 실제 prod에는 반영 안할 거 같아요.

@junseoplee junseoplee closed this Oct 8, 2024
@junseoplee junseoplee deleted the feature/61-redirect-uri-allocation branch October 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants