[Fix] 게시물 관련 QA (#57)

* fix: 게시물 수정 시 archive null 대응 (#56) * fix: 프롬프트 글자 제한 추가 (#56)
Someup · Oct 4, 2024 · 1dd85ab · 1dd85ab
1 parent c139511
commit 1dd85ab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/main/java/project/backend/business/archive/implement/ArchiveReader.java b/src/main/java/project/backend/business/archive/implement/ArchiveReader.java
@@ -14,6 +14,14 @@ public class ArchiveReader {
 
   private final ArchiveRepository archiveRepository;
 
+  public Archive readActivatedArchiveByIdIfNotNull(Long archiveId) {
+    if (archiveId == null) {
+      return null;
+    }
+    return archiveRepository.findByIdAndActivatedTrue(archiveId)
+                            .orElseThrow(() -> new CustomException(ErrorCode.BAD_REQUEST));
+  }
+
   public Archive readActivatedArchiveById(Long archiveId) {
     return archiveRepository.findByIdAndActivatedTrue(archiveId)
                             .orElseThrow(() -> new CustomException(ErrorCode.BAD_REQUEST));

diff --git a/src/main/java/project/backend/business/post/implement/PostManager.java b/src/main/java/project/backend/business/post/implement/PostManager.java
@@ -30,7 +30,7 @@ public Post createPost(User user, String url, SummaryResultDto summaryResultDto)
   }
 
   public Post updatePost(User user, Post post, UpdatePostServiceRequest updatePostServiceRequest) {
-    Archive archive = archiveReader.readActivatedArchiveById(
+    Archive archive = archiveReader.readActivatedArchiveByIdIfNotNull(
         updatePostServiceRequest.getArchiveId());
 
     post.updatePost(user, updatePostServiceRequest.getTitle(),

diff --git a/src/main/java/project/backend/business/post/implement/SummaryManager.java b/src/main/java/project/backend/business/post/implement/SummaryManager.java
@@ -46,7 +46,8 @@ private Prompt createPrompt(CreatePostServiceRequest createPostServiceRequest) {
 
     String promptMessage = "URL: " + createPostServiceRequest.getUrl() + "\n" +
         "Summarize the website corresponding to the URL below in a blog style according to the following summary conditions.\n"
-        + "Please also recommend the title\n"
+        + "Please also recommend the title, composed only of English letters or Hangul, and "
+        + "ensure it is less than 30 characters, including spaces.\n"
         + "The answer is given in json format string with title and content as keys.\n"
         + "Translate the content into the summary language!\n"
         + "Summary conditions: \n"