#111. Add more coverage on Json helper

SoliDry · Jun 11, 2018 · 4c45da6 · 4c45da6
1 parent aabc035
commit 4c45da6
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 17 deletions.
diff --git a/tests/_data/ArticleFixture.php b/tests/_data/ArticleFixture.php
@@ -28,11 +28,21 @@ public static function createAndGet() : Article
         return $article;
     }
 
+    public static function getCollection($params)
+    {
+        return Article::where($params)->get();
+    }
+
     /**
      * @param $id
      */
     public static function delete($id) : void
     {
         Article::destroy($id);
     }
+
+    public static function truncate()
+    {
+        Article::truncate();
+    }
 }
diff --git a/tests/unit/blocks/MigrationsTest.php b/tests/unit/blocks/MigrationsTest.php
@@ -48,7 +48,7 @@ public function setUp()
             ]
         ];
         $this->gen->objectName    = 'Article';
-        $this->gen->version       = 'v2';
+        $this->gen->version       = self::MODULE_NAME;
         $this->gen->modulesDir    = DirsInterface::MODULES_DIR;
         $this->gen->middlewareDir = DirsInterface::MIDDLEWARE_DIR;
         $this->gen->migrationsDir = DirsInterface::MIGRATIONS_DIR;

diff --git a/tests/unit/controllers/GeneratorTraitTest.php b/tests/unit/controllers/GeneratorTraitTest.php
@@ -5,6 +5,7 @@
 
 use rjapi\controllers\GeneratorTrait;
 use rjapi\types\ConsoleInterface;
+use rjapi\types\DirsInterface;
 use rjapitest\unit\TestCase;
 
 class GeneratorTraitTest extends TestCase

diff --git a/tests/unit/helpers/JsonTest.php b/tests/unit/helpers/JsonTest.php
@@ -6,12 +6,14 @@
 use League\Fractal\Resource\Item;
 use Modules\V2\Entities\Article;
 use Modules\V2\Http\Middleware\ArticleMiddleware;
+use PHPUnit\Framework\Constraint\IsType;
 use PHPUnit_Framework_MockObject_MockObject;
 use rjapi\extension\BaseFormRequest;
 use rjapi\extension\BaseModel;
 use rjapi\extension\JSONApiInterface;
 use rjapi\helpers\Json;
 use rjapi\types\RamlInterface;
+use rjapitest\_data\ArticleFixture;
 use rjapitest\unit\TestCase;
 
 /**
@@ -146,20 +148,15 @@ public function it_encodes_decodes_json()
         ], Json::decode('{"title":"Foo Bar Baz"}'));
     }
 
-//    /**
-//     * @test
-//     */
-//    public function it_gets_relations()
-//    {
-//        $collection = new Collection();
-////        $items = new class extends \ArrayAccessible {
-////
-////        };
-////        $items->offsetSet(0, 'title')
-//        $collection->add([
-//            'title' => 'Foo Bar Baz'
-//        ]);
-//        $rels = Json::getRelations($collection, 'article');
-//        print_r($rels);
-//    }
+    /**
+     * @test
+     */
+    public function it_gets_relations()
+    {
+        ArticleFixture::createAndGet();
+        $articles = ArticleFixture::getCollection([['topic_id', '>=', 1]]);
+        $rels = Json::getRelations($articles, 'article');
+        $this->assertInternalType(IsType::TYPE_ARRAY, $rels);
+        ArticleFixture::truncate();
+    }
 }