Implement device enumeration for WASAPI driver backend #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I don't know WASAPI so I can't attest on the quality of the platform code, though, I'll trust that it is correct. I'll wait before merging this, first to fix the compilation error issues, and also because there's a few changes I'm making to the main API (most of which we have discussed on Discord). |
|
I'll update CI for a Windows build as a separate PR once this is merged. Unless you want it as part of this one? |
geom3trik
force-pushed
the
wasapi
branch
3 times, most recently
from
bdae913 to
24f0f24
Compare
SolarLiner
approved these changes
Jul 28, 2024
examples/enumerate.rs
Outdated
| @@ -8,15 +8,15 @@ pub fn enumerate_devices<Driver: AudioDriver>(driver: Driver) -> Result<(), Box< | |||
| for device_type in [DeviceType::Input, DeviceType::Output, DeviceType::Duplex] { | |||
| eprint!("\t{device_type:?}:\t"); | |||
| if let Some(device) = driver.default_device(device_type)? { | |||
| eprintln!("{}", device.name()); | |||
| eprintln!("{}", device.name().unwrap()); | |||
There was a problem hiding this comment.
Suggested change
| eprintln!("{}", device.name().unwrap()); | |
| eprintln!("{}", device.name()?); |
examples/enumerate.rs
Outdated
| } else { | ||
| eprintln!("None"); | ||
| } | ||
| } | ||
|
|
||
| eprintln!("All devices"); | ||
| for device in driver.list_devices()? { | ||
| eprintln!("\t{} ({:?})", device.name(), device.device_type()); | ||
| eprintln!("\t{} ({:?})", device.name().unwrap(), device.device_type()); |
There was a problem hiding this comment.
Suggested change
| eprintln!("\t{} ({:?})", device.name().unwrap(), device.device_type()); | |
| eprintln!("\t{} ({:?})", device.name()?, device.device_type()); |
Didn't see that message! It would be great to have the CI added here directly, makes it easier to validate the PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.