Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial PublishValuesRequest implementation for OpenProviderStream #2

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Initial PublishValuesRequest implementation for OpenProviderStream #2

merged 1 commit into from
Jul 30, 2024

Conversation

rafaeling
Copy link

No description provided.

@rafaeling rafaeling requested a review from lukasmittag July 17, 2024 11:28
lukasmittag
lukasmittag reviewed Jul 18, 2024
View reviewed changes
Copy link

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first bunch of comments. Wrote them on 30% brain capacity. Will have a look some time later again.

databroker/src/grpc/sdv_databroker_v1/conversions.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v1/conversions.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/conversions.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/conversions.rs Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/conversions.rs Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Outdated Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Show resolved Hide resolved
databroker/src/grpc/kuksa_val_v2/val.rs Show resolved Hide resolved
databroker/src/main.rs Show resolved Hide resolved
databroker/src/viss/v2/conversions.rs Outdated Show resolved Hide resolved
lukasmittag
lukasmittag reviewed Jul 24, 2024
View reviewed changes
Copy link

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

databroker/src/grpc/kuksa_val_v2/conversions.rs Outdated Show resolved Hide resolved
@rafaeling rafaeling force-pushed the feature/open-provider-stream branch 2 times, most recently from b26a1b8 to f5f3629 Compare July 25, 2024 08:36
@rafaeling rafaeling force-pushed the feature/open-provider-stream branch from f5f3629 to f22df6f Compare July 30, 2024 09:00
@rafaeling rafaeling merged commit f66e34a into rel-0.5.0 Jul 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmittag lukasmittag lukasmittag left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaeling @lukasmittag