Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmaslecture v1 Tim Nolle #4

Open
wants to merge 4 commits into
base: xmaslecturev1
Choose a base branch
from

Conversation

tn4799
Copy link

@tn4799 tn4799 commented Sep 11, 2021

I've added subtraction and division to the calculator, currently working on a switch between evaluation and brackets, but its still WiP. When its done it will be pushed to this branch as well.

@tn4799 tn4799 changed the title xmaslecture v1 xmaslecture v1 Tim Nolle Sep 11, 2021
Copy link
Member

@tthuem tthuem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only a minor comment.

@@ -1,3 +1,5 @@
ProfCalculator/.classpath
.project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not a got idea to ignore these files. These are needed for others to import the project.

@tthuem tthuem changed the base branch from main to xmaslecturev0 October 1, 2021 09:55
@tthuem tthuem changed the base branch from xmaslecturev0 to xmaslecturev1 October 1, 2021 09:56
tthuem added a commit that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants