Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instagram provider merge code fields #1177

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

kife-design
Copy link

Align the getCodeFields method with the AbstractProvider.php where the CodeFields are merged with the external parameters.

Merge fields with passed parameters
@kife-design
Copy link
Author

We are using instagrambasic and instagram graph api in one project. They share the same code, and a custom parameter is passed to the redirect using the with() method.

In the instagram basic provider, the custom param is not passed because it doe not merge the code fields with the provided parameters. This pull request fixes that issue.

Create from parent fields and replace app_id
@lucasmichot lucasmichot requested a review from atymic March 29, 2024 08:40
@atymic atymic changed the title Update Provider.php fix: instagram provider merge code fields Apr 1, 2024
@atymic atymic merged commit ea61370 into SocialiteProviders:master Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants