Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Clerk provider #1153

Merged

Conversation

ignaciojcano
Copy link
Contributor

Implements the provider for Clerk

Their OAuth2 usage guide is found here

Created the provider using the generator and used the Auth0 one as a guide

Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick comment, otherwise looks good.

/**
* {@inheritdoc}
*/
protected function getTokenFields($code)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed or the same as the parent method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as parent, i'll remove this and ensure it is working

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atymic it's been addressed

Ignacio José Canó Cabral and others added 2 commits February 18, 2024 14:03
@lucasmichot lucasmichot self-requested a review February 19, 2024 12:15
Copy link
Member

@lucasmichot lucasmichot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM @atymic

@atymic atymic merged commit d15b16f into SocialiteProviders:master Feb 19, 2024
4 checks passed
@atymic
Copy link
Member

atymic commented Feb 19, 2024

Please PR the website repo @ignaciojcano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants