Trophy Icon Fix #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue with the logic where the trophy icon was being applied for the top 3 players on each page rather than the top 3 players for the map overall
Update view_map.php
|
@sneak-it Let me know if you want me to reopen and push the changes to a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses the issue where trophy icons were displayed for the top 3 players on each page of the view_map.php file, rather than the top 3 players overall for the map.
Changes:
xto account for the current page number. This ensures thatxstarts at the correct rank for each page.x, but with the adjusted initialization, only the top 3 players overall will receive the trophy icon.This fix is for issue: #5