Use CStr literals everywhere possible #1472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
force-pushed
the
edition-2021-cstr-literals
branch
from
77d710e to
d0c1d92
Compare
i509VCB
reviewed
Jun 30, 2024
This is required for c"" CStr literals.
It only uses it to pass it to a syscall, so it doesn’t need ownership of it.
linkmauve
force-pushed
the
edition-2021-cstr-literals
branch
from
d0c1d92 to
e91165e
Compare
This addition to the 2021 edition makes it possible to generate a &CStr at compile-time, with no need for unwrap()/expect() or unsafe, making it much more ergonomic to pass to C APIs.
linkmauve
force-pushed
the
edition-2021-cstr-literals
branch
from
e91165e to
fc12195
Compare
|
Thanks, looks good in general. Unfortunately bumping the MSRV is not an option at the moment. I will try to make sure we can do this in the near future, but this has to wait until we are able to bump the MSRV in some projects that depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition to the 2021 edition makes it possible to generate a
&CStrat compile-time, with no need forunwrap()/expect()orunsafe, making it much more ergonomic to pass to C APIs.I’ve also modified the
SealedStringconstructors to take a&CStrinstead of aCStringsince it only needs to use it, not keep ownership of it.This requires to bump the MSRV to 1.77 so I just did.