xdg-activation: Add client_id to token data #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
reviewed
Nov 6, 2023
| @@ -87,7 +87,7 @@ where | |||
| { | |||
| fn request( | |||
| state: &mut D, | |||
| _: &Client, | |||
| client: &Client, | |||
There was a problem hiding this comment.
I'd wonder would the ClientId be preferable or pass a whole Client? You can get the id from a Client but also do lookup on the Client you get.
There was a problem hiding this comment.
The original client could disconnect before the token is used by another client. I didn't want to force the object to keep on living. In that sense it serves as an Option<Client>.
So in token_created this will always be a valid id, but in request_activation it might not be.
PolyMeilex
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to special case certain (e.g. privileged) clients, as surface and seat (which could otherwise be used to get the client) are optional.