Make XdgShellHandler::reposition_request mandatory #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a GTK4 application which tries to reposition a popup surface, it will wait for a commit to confirm the repositioning and halt all rendering. To avoid compositors accidentally skipping the implementation of this function, it should be clearly indicated that this is mandatory. The documentation was also expanded to reinforce this point.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
=======================================
Coverage 21.98% 21.98%
=======================================
Files 154 154
Lines 24094 24093 -1
=======================================
+ Hits 5297 5298 +1
+ Misses 18797 18795 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Drakulix
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a GTK4 application which tries to reposition a popup surface, it will wait for a commit to confirm the repositioning and halt all rendering.
To avoid compositors accidentally skipping the implementation of this function, it should be clearly indicated that this is mandatory. The documentation was also expanded to reinforce this point.