Support for v2 #10
Merged
Support for v2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of just linking to libdisplay-info use system-deps, which will use pkg-config internally, to resolve the native lib. this also limits the version to the currently supported one
cmeissl
force-pushed
the
feature/v2
branch
5 times, most recently
from
901c059 to
eee9743
Compare
cmeissl
commented
Jan 3, 2025
...contain libdisplay-info 0.2.0
ids1024
reviewed
Jan 3, 2025
| let deps = system_deps::Config::new().probe().unwrap(); | ||
| let native_lib = deps.get_by_name("libdisplay-info").unwrap(); | ||
| let native_version = semver::Version::parse(&native_lib.version).unwrap(); | ||
| let has_v2 = semver::VersionReq::parse(">=0.2") |
There was a problem hiding this comment.
Should we error here on >= 0.3, assuming that would be another breaking change?
There was a problem hiding this comment.
yeah, that is probably a good idea. added a commit to restrict the max version directly in the system_deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit changes the current version (bumping it to 0.1.1) to resolve the native lib using pkg-config and limiting it to 0.1 if the native lib.
Second commit adds support for 0.2, which can explicitly be enabled with a
v0_2feature flag.In addition the build script enabled linking against 0.2 when the version is detected.
The safe wrapper should handle the
i32<>i64compatibility just fine and only expose 0.2 features whenthe corresponding feature flag is enabled.
Most things are just additions or compatible changes with the exception of the data type of
max_pixel_clock_hzin thedi_edid_display_range_limits.To solve this the
-syscrate exports the type depending on the actual found native lib version like this:The safe wrapper will now always use
i64and just usei64::fromto convert from thedi_edid_display_range_limits_max_pixel_clock_hzvalue.TODO
fixes #9