Feat/page search result document card integration #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Nov 9, 2023
•
ghost
commented
- Modification du composant documentCard pour correspondre à la maquette (taille image)
- Intégration de documentCard sur la page searchPage
- Suppression des fonctions inutile pour la page démo (éléments static)
- Modification du composant FoldableColumnLayout pour que la colonne de droite preine la pleine largeur quand la colonne de gauche est désactive
|
ghost
requested review from
MorganeLeCaignec
approved these changes
Nov 9, 2023
tonai
pushed a commit
that referenced
this pull request
Nov 10, 2023
* feat(redmine 1245005): add DocumentCard component * feat(redmine 1245005): fix display 12 col if filters is desable
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2023
* refactor(redmine 1246965): added SearchBar as sub-component of HeaderSearch (#50) * feat(redmine 1246965): added SearchBar sub-component of HeaderSearch, added leftSection to SearchBar * feat: update Sidebar and CollapseButton to be compatible with routing (#51) * feat: use paper for infoCard, update test page and refactor Pagination itemsPerPage (#53) * feat(redmine 1245005): added `SearchResults` example page (#54) * feat(redmine 1245005): added `SearchResults` example page refactor: modified `Pagination`, `SearchBar`, `Header` and `FoldableColumnLayout` * fix: remove Appshell from FoldableColumnLayout (#55) * feat(redmine 1246946): added `SwitchableDataView` component with SegmentedControl (#56) * feat(redmine 1246946): added `SwitchableDataView` component with SegmentedControl * fix: pr * fix: pr * fix: pr * fix: pr * feat(redmine 1246945): add Thumbnail component and fileIcon component * feat(redmine 1246945): add Thumbnail component * feat(redmine 1246945): fix pr review * feat(redmine 1246945): remove fileExtendtType file and Add FileExtendType component * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix pr review * feat(redmine 1246945): add confirm modal feature * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix import error --------- Co-authored-by: Quentin Le Caignec <[email protected]> * Feat/document_card (#60) * feat(redmine 1246977): add listViewItem component and add strucutre * feat(redmine 1246977): add style for listViewItem * feat(redmine 1246977): change name of listViewItem to DocumentCard * feat(redmine 1246977): change name of listViewItem to DocumentCard * feat(redmine 1246977): remove not used style * feat(redmine 1246977): fix review pr * feat: include Pagination component inside Table component (#59) * Feat/page search result document card integration (#61) * feat(redmine 1245005): add DocumentCard component * feat(redmine 1245005): fix display 12 col if filters is desable * ci: version packages * feat(redmine 1246959): integration of active fiters zone * feat(redmine 1246959): integration of active fiters zone * feat(redmine 1246959): Add bottom of component filter * feat(redmine 1246959): Add functions * feat(redmine 1246959): Add component SidebarFilterMenu * feat(redmine 1246959): change location of SidebarFilterMenu and desable vertical ligne for the collapse * feat(redmine 1246959): fix type errors * feat(redmine 1246959): change style of collapseButtonControlled for filters * feat(redmine 1246959): fix lint error * feat(redmine 1246959): add changeset * feat(redmine 1246959): fix eslint error * feat(redmine 1246959): fix change from pr review by Quentin * feat(redmine 1246959): fix pr review by Tony * feat(redmine 1246959): fix typo error * feat(redmine 1246959): fix pr return from Tony for eslint error and collapseProps * feat(redmine 1246959): fix pr review type of collapseProps --------- Co-authored-by: Quentin Le Caignec <[email protected]> Co-authored-by: Tony Cabaye <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tonai
added a commit
that referenced
this pull request
Nov 24, 2023
* refactor(redmine 1246965): added SearchBar as sub-component of HeaderSearch (#50) * feat(redmine 1246965): added SearchBar sub-component of HeaderSearch, added leftSection to SearchBar * feat: update Sidebar and CollapseButton to be compatible with routing (#51) * feat: use paper for infoCard, update test page and refactor Pagination itemsPerPage (#53) * feat(redmine 1245005): added `SearchResults` example page (#54) * feat(redmine 1245005): added `SearchResults` example page refactor: modified `Pagination`, `SearchBar`, `Header` and `FoldableColumnLayout` * fix: remove Appshell from FoldableColumnLayout (#55) * feat(redmine 1246946): added `SwitchableDataView` component with SegmentedControl (#56) * feat(redmine 1246946): added `SwitchableDataView` component with SegmentedControl * fix: pr * fix: pr * fix: pr * fix: pr * feat(redmine 1246945): add Thumbnail component and fileIcon component * feat(redmine 1246945): add Thumbnail component * feat(redmine 1246945): fix pr review * feat(redmine 1246945): remove fileExtendtType file and Add FileExtendType component * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix pr review * feat(redmine 1246945): add confirm modal feature * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix pr review * feat(redmine 1246945): fix import error --------- Co-authored-by: Quentin Le Caignec <[email protected]> * Feat/document_card (#60) * feat(redmine 1246977): add listViewItem component and add strucutre * feat(redmine 1246977): add style for listViewItem * feat(redmine 1246977): change name of listViewItem to DocumentCard * feat(redmine 1246977): change name of listViewItem to DocumentCard * feat(redmine 1246977): remove not used style * feat(redmine 1246977): fix review pr * feat: include Pagination component inside Table component (#59) * Feat/page search result document card integration (#61) * feat(redmine 1245005): add DocumentCard component * feat(redmine 1245005): fix display 12 col if filters is desable * ci: version packages * feat(redmine 1246959): integration of active fiters zone * feat(redmine 1246959): integration of active fiters zone * feat(redmine 1246959): Add bottom of component filter * feat(redmine 1246959): Add functions * feat(redmine 1246959): Add component SidebarFilterMenu * feat(redmine 1246959): change location of SidebarFilterMenu and desable vertical ligne for the collapse * feat(redmine 1246959): fix type errors * feat(redmine 1246959): change style of collapseButtonControlled for filters * feat(redmine 1246959): fix lint error * feat(redmine 1246959): add changeset * feat(redmine 1246959): fix eslint error * feat(redmine 1246959): fix change from pr review by Quentin * feat(redmine 1246959): fix pr review by Tony * feat(redmine 1246959): fix typo error * feat(redmine 1246959): fix pr return from Tony for eslint error and collapseProps * feat(redmine 1246959): fix pr review type of collapseProps --------- Co-authored-by: Quentin Le Caignec <[email protected]> Co-authored-by: Tony Cabaye <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.