Merge branch '0.16.x' into Fix/ButtonAccessibilityError

Smile-SA · Aug 12, 2024 · f00a3f9 · f00a3f9
2 parents 8d31883 + 3d27f22
commit f00a3f9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/proud-clocks-try.md b/.changeset/proud-clocks-try.md
@@ -0,0 +1,5 @@
+---
+'@smile/haring-react': minor
+---
+
+correction to accessibility error dropdownMenu (focusable element)
diff --git a/packages/haring-react/src/Components/DropdownButton/DropdownButton.tsx b/packages/haring-react/src/Components/DropdownButton/DropdownButton.tsx
@@ -38,6 +38,7 @@ export function DropdownButton(props: IDropdownButtonProps): ReactElement {
       <Menu.Target>
         {buttonComponent ?? (
           <Button
+            component="span"
             data-testid="button"
             rightSection={opened ? <CaretUp /> : <CaretDown />}
           >

diff --git a/...ges/haring-react/src/Components/DropdownButton/__snapshots__/DropdownButton.test.tsx.snap b/...ges/haring-react/src/Components/DropdownButton/__snapshots__/DropdownButton.test.tsx.snap
@@ -12,7 +12,7 @@ exports[`DropdownButton matches snapshot 1`] = `
   >
     @media (max-width: 35.99375em) {.mantine-visible-from-xs {display: none !important;}}@media (min-width: 36em) {.mantine-hidden-from-xs {display: none !important;}}@media (max-width: 47.99375em) {.mantine-visible-from-sm {display: none !important;}}@media (min-width: 48em) {.mantine-hidden-from-sm {display: none !important;}}@media (max-width: 61.99375em) {.mantine-visible-from-md {display: none !important;}}@media (min-width: 62em) {.mantine-hidden-from-md {display: none !important;}}@media (max-width: 74.99375em) {.mantine-visible-from-lg {display: none !important;}}@media (min-width: 75em) {.mantine-hidden-from-lg {display: none !important;}}@media (max-width: 87.99375em) {.mantine-visible-from-xl {display: none !important;}}@media (min-width: 88em) {.mantine-hidden-from-xl {display: none !important;}}
   </style>
-  <button
+  <span
     aria-controls=":r0:-dropdown"
     aria-expanded="false"
     aria-haspopup="menu"
@@ -21,7 +21,6 @@ exports[`DropdownButton matches snapshot 1`] = `
     data-with-right-section="true"
     id=":r0:-target"
     style="--button-color: var(--mantine-color-white);"
-    type="button"
   >
     <span
       class="m_80f1301b mantine-Button-inner"
@@ -48,6 +47,6 @@ exports[`DropdownButton matches snapshot 1`] = `
         </svg>
       </span>
     </span>
-  </button>
+  </span>
 </div>
 `;