feat(redmine 1306617): accessibility correction unsupported aria attr… (

#210) * feat(redmine 1306617): accessibility correction unsupported aria attribute
Smile-SA · Sep 26, 2024 · 8d4ed77 · 8d4ed77
1 parent 03664ad
commit 8d4ed77
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 33 deletions.
diff --git a/.changeset/clever-worms-breathe.md b/.changeset/clever-worms-breathe.md
@@ -0,0 +1,5 @@
+---
+'@smile/haring-react': minor
+---
+
+Accessibility Correction unsupported ARIA attributes
diff --git a/packages/haring-react/src/Components/CollapseButton/CollapseButtonControlled.tsx b/packages/haring-react/src/Components/CollapseButton/CollapseButtonControlled.tsx
@@ -83,7 +83,6 @@ export function CollapseButtonControlled<
   return (
     <>
       <Button
-        aria-expanded={opened ? 'true' : 'false'}
         classNames={{
           label: labelClasses.join(' '),
           root: rootClasses.join(' '),

diff --git a/...ges/haring-react/src/Components/CollapseButton/__snapshots__/CollapseButton.test.tsx.snap b/...ges/haring-react/src/Components/CollapseButton/__snapshots__/CollapseButton.test.tsx.snap
@@ -13,7 +13,6 @@ exports[`CollapseButton matches snapshot 1`] = `
     @media (max-width: 35.99375em) {.mantine-visible-from-xs {display: none !important;}}@media (min-width: 36em) {.mantine-hidden-from-xs {display: none !important;}}@media (max-width: 47.99375em) {.mantine-visible-from-sm {display: none !important;}}@media (min-width: 48em) {.mantine-hidden-from-sm {display: none !important;}}@media (max-width: 61.99375em) {.mantine-visible-from-md {display: none !important;}}@media (min-width: 62em) {.mantine-hidden-from-md {display: none !important;}}@media (max-width: 74.99375em) {.mantine-visible-from-lg {display: none !important;}}@media (min-width: 75em) {.mantine-hidden-from-lg {display: none !important;}}@media (max-width: 87.99375em) {.mantine-visible-from-xl {display: none !important;}}@media (min-width: 88em) {.mantine-hidden-from-xl {display: none !important;}}
   </style>
   <div
-    aria-expanded="false"
     class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
     data-block="true"
     data-size="md"

diff --git a/packages/haring-react/src/Components/HeaderMenu/__snapshots__/HeaderMenu.test.tsx.snap b/packages/haring-react/src/Components/HeaderMenu/__snapshots__/HeaderMenu.test.tsx.snap
@@ -130,7 +130,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
     style="padding: 0rem;"
   >
     <div
-      aria-expanded="false"
       class="haring-focus haring-active    m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -191,7 +190,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
       style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
     >
       <div
-        aria-expanded="false"
         class="haring-focus haring-active      m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -217,7 +215,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
         </span>
       </div>
       <div
-        aria-expanded="false"
         class="haring-focus haring-active      m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -243,7 +240,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
         </span>
       </div>
       <div
-        aria-expanded="false"
         class="haring-focus haring-active      m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -304,7 +300,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
         style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
       >
         <div
-          aria-expanded="false"
           class="haring-focus haring-active      m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -330,7 +325,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
           </span>
         </div>
         <div
-          aria-expanded="false"
           class="haring-focus haring-active      m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -357,7 +351,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
         </div>
       </div>
       <div
-        aria-expanded="false"
         class="haring-focus haring-active      m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -384,7 +377,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
       </div>
     </div>
     <div
-      aria-expanded="false"
       class="haring-focus haring-active    m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -410,7 +402,6 @@ exports[`HeaderMenu matches snapshot in mobile mode 1`] = `
       </span>
     </div>
     <div
-      aria-expanded="false"
       class="haring-focus haring-active    m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"

diff --git a/...ges/haring-react/src/Components/SidebarFilters/__snapshots__/SidebarFilters.test.tsx.snap b/...ges/haring-react/src/Components/SidebarFilters/__snapshots__/SidebarFilters.test.tsx.snap
@@ -17,7 +17,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
   >
     <div>
       <div
-        aria-expanded="true"
         class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-size="md"
@@ -219,7 +218,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
         style="padding: 0rem;"
       >
         <div
-          aria-expanded="true"
           class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -419,7 +417,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
           </div>
         </div>
         <div
-          aria-expanded="true"
           class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -480,7 +477,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
           style="box-sizing: border-box; opacity: 1; transition: opacity 200ms ease; border-top: 1px solid #dee2e6;"
         >
           <div
-            aria-expanded="true"
             class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
             data-block="true"
             data-selected="false"
@@ -634,7 +630,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
             </div>
           </div>
           <div
-            aria-expanded="true"
             class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
             data-block="true"
             data-selected="false"
@@ -744,7 +739,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
           </div>
         </div>
         <div
-          aria-expanded="false"
           class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -770,7 +764,6 @@ exports[`SidebarFilters matches snapshot 1`] = `
           </span>
         </div>
         <div
-          aria-expanded="false"
           class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"

diff --git a/packages/haring-react/src/Components/SidebarMenu/__snapshots__/SidebarMenu.test.tsx.snap b/packages/haring-react/src/Components/SidebarMenu/__snapshots__/SidebarMenu.test.tsx.snap
@@ -16,7 +16,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
     class="m_1b7284a3 mantine-Paper-root"
   >
     <div
-      aria-expanded="false"
       class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -104,7 +103,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
     >
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -131,7 +129,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       </div>
     </div>
     <div
-      aria-expanded="false"
       class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -219,7 +216,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
     >
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -246,7 +242,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       </div>
     </div>
     <div
-      aria-expanded="false"
       class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -334,7 +329,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
     >
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -360,7 +354,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
         </span>
       </div>
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -421,7 +414,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
         style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
       >
         <div
-          aria-expanded="false"
           class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -448,7 +440,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
         </div>
       </div>
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -475,7 +466,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       </div>
     </div>
     <div
-      aria-expanded="false"
       class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -528,7 +518,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       </span>
     </div>
     <div
-      aria-expanded="false"
       class="haring-focus haring-active m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
       data-block="true"
       data-selected="false"
@@ -616,7 +605,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
       style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
     >
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"
@@ -677,7 +665,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
         style="box-sizing: border-box; opacity: 0; transition: opacity 200ms ease; display: none; height: 0px; overflow: hidden;"
       >
         <div
-          aria-expanded="false"
           class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -703,7 +690,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
           </span>
         </div>
         <div
-          aria-expanded="false"
           class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
           data-block="true"
           data-selected="false"
@@ -730,7 +716,6 @@ exports[`SidebarMenu matches snapshot 1`] = `
         </div>
       </div>
       <div
-        aria-expanded="false"
         class="haring-focus haring-active   m_77c9d27d mantine-Button-root m_87cf2631 mantine-UnstyledButton-root"
         data-block="true"
         data-selected="false"