Skip to content

Commit

Permalink
Feat/aria tabs (#211)
Browse files Browse the repository at this point in the history
* feat(redmine 1306631): correction to tabs role
  • Loading branch information
Meriemu authored Aug 9, 2024
1 parent 85e6198 commit 0f0d647
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/khaki-planets-design.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@smile/haring-react': minor
---

correction to dropdownMenu role
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface IDropdownButtonProps extends MenuProps {
buttonComponent?: ReactNode;
children?: ReactNode;
label?: string;
role?: string;
}

/** Additional props will be forwarded to the [Mantine Menu component](https://mantine.dev/core/menu) */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export function ResponsiveTabs(props: IResponsiveTabs): ReactNode {
onChange={setOpened}
opened={opened}
position="bottom-end"
role="tab"
{...dropdownButtonProps}
>
<div className={classes.dropdownContainer}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ exports[`ResponsiveTabs matches snapshot 1`] = `
class="haring-focus haring-active m_8d3f4000 mantine-ActionIcon-root m_87cf2631 mantine-UnstyledButton-root"
data-variant="subtle"
id="responsive-tabs-overflow-button-target"
role="tab"
style="--ai-radius: var(--mantine-radius-sm); --ai-bg: transparent; --ai-hover: rgba(0, 0, 0, 0.12); --ai-color: gray-9; --ai-bd: calc(0.0625rem * var(--mantine-scale)) solid transparent;"
type="button"
>
Expand Down

0 comments on commit 0f0d647

Please sign in to comment.